Onboarding Design Experiment: Final fixes #6590
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mikescamell
force-pushed
the
feature/mike/onboarding-test/final-fixes
branch
from
a76b56d to
2666e96
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses animation timing and cleanup issues in the onboarding experience to prevent visual glitches and improve user interaction reliability. The changes focus on proper animation sequencing and resource management.
Key changes:
- Fixed animation timing by ensuring click listeners are only set after animations complete
- Added proper animation cleanup and cancellation to prevent memory leaks
- Improved handling of Buck magnifying glass animation hiding
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BbWelcomePage.kt | Initializes dialog title text to prevent empty content flashing |
| Cta.kt | Implements proper animation cleanup, tracks animators, and delays click listener setup |
| BrowserTabFragment.kt | Adds proper hiding of Buck magnifying glass animation for search options |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
…og opening It would result in some parts of the content e.g. the primary CTA button being visible when the dialog was opened and used for a new CTA type.
mikescamell
force-pushed
the
feature/mike/onboarding-test/final-fixes
branch
from
2666e96 to
a0e7453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207908166761516/task/1211042630873651?focus=true
Description
This PR fixes several animation issues in the onboarding experience:
Steps to test this PR
BB Fixes
Buck Fixes
UI changes
N/A